Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a consistency bug where changes made in one DuckDB connection are not immediately reflected in other DuckDB connections. Looks like the problem is that In the go-duckdb driver, the Open function creates a new DB handle (using duckdb_open) and new connection handle (using duckdb_connect) each time. So the use of multiple DB handles seems to be the problem here. Thanks @begelundmuller for the analysis.
Driver now implements
DriverContext
sosql.DB
will callOpenConnector
to obtain a Connector and then invokethat Connector's Connect method to obtain each needed connection instead of invoking Driver's Open method which was creating new
C.duckdb_database
each time. Now we create database object once on call toOpenConnector
and callC.duckdb_connect
on same database to obtain new connections on call toConnect
.