Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DuckDB to 0.7.0 #72

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Update DuckDB to 0.7.0 #72

merged 5 commits into from
Feb 15, 2023

Conversation

marcboeker
Copy link
Owner

No description provided.

@begelundmuller
Copy link
Contributor

Hey, I'm eager to try this out! I noticed the tests fails, it looks like it's just due to DuckDB removing the DUCKDB_TYPE_JSON type. Let me know if there's any way I can help.

@marcboeker
Copy link
Owner Author

I was a bit confused about that and already asked the DuckDB devs about this.

I've already removed the DuckDB JSON type, but now I'm having problems with the MAP type in the tests. I have to further investigate. The current state is pushed, if you have any ideas.

@begelundmuller
Copy link
Contributor

Bummer – maybe it's related to: duckdb/duckdb#5768?

@marcboeker
Copy link
Owner Author

Yeah that could exactly be the breaking change. I've asked them about this.

A lot of breaking changes for a minor version upgrade. To be fair, it's still pre 1.0.0 😃

@marcboeker
Copy link
Owner Author

@begelundmuller I've pushed a fix for the new map layout. Could you please have a look at it, if this looks good to you. Thanks!

@begelundmuller
Copy link
Contributor

begelundmuller commented Feb 15, 2023

@marcboeker, took a look at the changes and they seem good to me.

I'm wondering if it would be more performant to scan into a []struct {Key any, Value any}, but that would require refactoring the struct scanning, so doesn't make sense to do here (and I'm guessing Go's map is pretty optimized anyway).

@marcboeker
Copy link
Owner Author

took a look at the changes and they seem good to me.

Thanks!

I'm wondering if it would be more performant to scan into a []struct {Key any, Value any}, but that would require refactoring the struct scanning, so doesn't make sense to do here (and I'm guessing Go's map is pretty optimized anyway).

This would definitely be a better way. I was hoping that having a map with only two keys should be fast enough. But we can keep this improvement as a separate ticket. I'll create one.

@marcboeker marcboeker merged commit d2fdd02 into master Feb 15, 2023
@marcboeker marcboeker deleted the mboeker/duckdb-upgrade-0.7.0 branch February 15, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants