Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python HTTPTrigger Lesson #132

Merged
merged 38 commits into from Nov 23, 2021
Merged

Python HTTPTrigger Lesson #132

merged 38 commits into from Nov 23, 2021

Conversation

Dzvezdana
Copy link
Contributor

@Dzvezdana Dzvezdana commented Nov 17, 2021 •
edited

I added:

  • Python directory in src containing 4 Python lessons following the TypeScript template: basic HTTP Function App, changed the template for a GET request, changed the template for a POST request, and a custom "type-safe" function
  • homework (NLP application)
  • lesson markdowns for the HTTP examples, prerequisite, deployment, as well as the homework
  • project to the workspaces folder
  • tests

Only a tour is missing, but I'll add it after I gather some initial feedback on this PR.
Added tour files for the Python lessons and homework. I fixed some broken tour paths in the typescript project.

@Dzvezdana Dzvezdana changed the title [Python HTTP Lesson [WIP] Python HTTP Lesson Nov 17, 2021
@Dzvezdana Dzvezdana changed the title [WIP] Python HTTP Lesson Python HTTPTrigger Lesson Nov 17, 2021
@marcduiker marcduiker mentioned this pull request Nov 17, 2021
Closed
marcduiker
marcduiker requested changes Nov 17, 2021
View reviewed changes
Copy link
Owner

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good already! I only have some minor comments and things can need to be moved.

lessons/python/prerequisites/prerequisites-ts.md Outdated Show resolved Hide resolved
lessons/python/prerequisites/prerequisites-ts.md Outdated Show resolved Hide resolved
lessons/python/prerequisites/prerequisites-ts.md Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
marcduiker
marcduiker reviewed Nov 17, 2021
View reviewed changes
Copy link
Owner

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small file renames so the links keep working.

lessons/README.md Outdated Show resolved Hide resolved
lessons/python/http/http-lesson-python.md Outdated Show resolved Hide resolved
marcduiker
marcduiker requested changes Nov 21, 2021
View reviewed changes
Copy link
Owner

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things to clean up and to make sure CodeTour works from the Python HTTP lesson workspace.

.tours/typescript/http/.tours/01creating-a-function-app.tour Outdated Show resolved Hide resolved
.tours/python/http/.tours/01creating-a-function-app.tour Outdated Show resolved Hide resolved
src/python/AzureFunctions.Http/.vscode/launch.json Outdated Show resolved Hide resolved
src/python/AzureFunctions.Http/.vscode/tasks.json Outdated Show resolved Hide resolved
marcduiker
marcduiker approved these changes Nov 23, 2021
View reviewed changes
Copy link
Owner

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcduiker marcduiker merged commit 751ce47 into marcduiker:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcduiker marcduiker marcduiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dzvezdana @marcduiker @dana-cmd