Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero time occurence of BU name #3

Merged
merged 1 commit into from
May 17, 2020

Conversation

euttsov
Copy link

@euttsov euttsov commented May 15, 2020

By the dbc file format specification node name could be repeated from zero to multiple times.
This commit fix node name parsing allowing zero time name occurences.

By the dbc file format specification node name could be repeated from zero to multiple times.
This commit fix node name parsing allowing zero time name occurences.
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3 into dev will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev       #3      +/-   ##
==========================================
- Coverage   93.10%   92.75%   -0.35%     
==========================================
  Files           2        2              
  Lines         551      511      -40     
==========================================
- Hits          513      474      -39     
+ Misses         38       37       -1     
Impacted Files Coverage Δ
src/parser.rs 97.31% <100.00%> (+0.68%) ⬆️
src/lib.rs 80.57% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6bcbf...f54176f. Read the comment docs.

@marcelbuesing
Copy link
Owner

Awesome thanks for fixing this!

@marcelbuesing marcelbuesing merged commit 68e8785 into marcelbuesing:dev May 17, 2020
@marcelbuesing
Copy link
Owner

Released this as 3.0.1

@euttsov euttsov deleted the fix-node-parsing branch May 18, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants