Be more lenient about trailing spaces #4
Conversation
|
Awesome thanks for fixing this. I actually have experienced this as well. Sorry for not fixing it earlier. I haven't really found a good way yet to return proper errors, e.g. where exactly the parsing failed, I assume that would have helped as well. |
|
Thanks for the super quick merge! I'm writing a small codegen tool for embedded usage right now (right now it's way simpler than your dbcc) and I'll try to make more PRs when I run into other things :) |
|
I just released 3.0.2 containing the fix to crates.io. Btw by coincidence I saw you worked on bitsh I assume this could make some generated code in dbcc easier to read. Maybe this dbc viewer using this crate is also interesting for. Easiest way to start it is via docker. |
|
Wow, that was super quick, thanks! Yup, we have a small protoype with handwritting code right now. I'm in the process of cleaning that up, I'll ping you when I have a repo to show for it. bitsh will most likely be part of it, but maybe not with that name :) |
|
Looking forward to see that! I had actually planned on making dbcc useable with |
|
Pushed a first draft here, will try to keep it updated with the code we actually put on devices :) |
Hi, I've recently used canmatrix to generate a dbc file (from kcd) and can-dbc had some issues parsing it. Figuring out what went wrong took me about an hour, but the fix was rather trivial -- it was just a bunch of trailing spaces.