Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit CodePagesEncodingProvider to add .net core compatibility #47

Closed
wants to merge 1 commit into from

Conversation

mlof
Copy link

@mlof mlof commented Dec 29, 2018

No description provided.

@marceldev89
Copy link
Owner

Thank you. Is the library broken without this change?

@tym32167
Copy link
Contributor

tym32167 commented Feb 25, 2019

Why do 3 party library should care about client stuff like encoding? This is ASP.NET core issue, not .NET starndard. Lets client to decide how to handle encoding issues. Battlenet - made as Standard 2.0 library and it can be used not only with Asp.NET core 2. Moreover, setting encoding in BattleyeClient class? This is not a purpose to do things like that. If you have asp.net core app - please, setup encoding inside Startup class and dont mix this with Battleye code. Voting to reject this PR and close.

@Vipeax
Copy link
Collaborator

Vipeax commented Feb 25, 2019

I agree with @tym32167.

@marceldev89
Copy link
Owner

marceldev89 commented Feb 25, 2019

I keep mistaking the differences between all the .NET versions these days.. Haven't been in the .NET realm for a while now and assumed it might have broken something somewhere. But I agree, this is probably not a job for the library. Thanks for the effort though. ❤️

#47 (comment)

I agree with @tym32167.

He's alive! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants