New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name of the preference extensions.yslow.beaconInfo not the same as used in documentation #5

Closed

mtolk opened this issue Feb 20, 2012 · 1 comment

mtolk commented Feb 20, 2012

In the YSlow documentation( http://developer.yahoo.com/yslow/help/beacons.html#version2 ) the preference extensions.yslow.beaconInfo is mentioned. This is inconsistent with the preference name used in the code.

In the code /src/common/view.js line 413
info = pref.getPref('info', 'basic'),

This uses the preference extensions.yslow.info.

I'm not sure if the documentation or the code needs changing.

marcelduran pushed a commit that referenced this issue


          just fixed issue #5

438be3d

marcelduran pushed a commit that referenced this issue


          just fixed issue #5

4b30241

Owner

marcelduran commented Feb 20, 2012

fixed, the correct was beaconInfo, the issue is #5 not #7

marcelduran closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment