-
Notifications
You must be signed in to change notification settings - Fork 713
Performance issue in the dragover event of the dndLists directive. #413
Comments
amazing job @johntdowney |
Awesome Job! Can Someone add it into the original source? |
Glad I could help! I see this "Close and comment" button, but I'm not sure of the etiquette here regarding whether or not I should close this issue since I opened it, so I'll just hit the comment button instead and assume someone with more authority can close it once the change has been applied. |
@marceljuenemann please review the PR, and run the minifier. |
Awesome! Thank you so much, that improve a lot than the original. |
See issue marceljuenemann#413 from origin about layout trashing. Signed-off-by: Emmanuel Olowosulu <eolowo@sulusoft.com>
Fantastic, thanks @johntdowney ! Has a PR been submitted for this fix? |
following marceljuenemann#413 issue, solution credit goes to @johntdowney;
Thank you so much! I would like this library to be updated more constantly, the last update is from 2017! |
You can improve performance a bit more by throttling:
|
I also added some throttling, using lodash.
with
you'll also need to get rid of the extra bracket etc. at the end of the function |
Hey, just leaving this here for the author and/or those who care because I spent a little while solving this issue while working with a very large drag and drop list.
Line 339/340 is as follows:
Replacing these two lines with
dramatically cuts down on the number of DOM layouts and improves the execution time of the dragover event handler. Without this, it's pretty hobbled at around ~60 dnd list items.
Thanks,
John Downey
The text was updated successfully, but these errors were encountered: