Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

Don't stop propagation of click event if dnd is disabled #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rysilva
Copy link

@rysilva rysilva commented Sep 10, 2015

Don't stop propagation of click event if dnd is disabled. Fixes 131

Don't know how you typically generate the min file, but I've updated the non-minified file.

@marceljuenemann marceljuenemann added this to the 1.4.0 milestone Oct 19, 2015
@marceljuenemann
Copy link
Owner

Thanks for contributing, will merge with next release

@marceljuenemann
Copy link
Owner

One problem I see: With nested lists, the dnd-selected callback would be fired on the disabled element, as well as any parent dnd-draggable element. I'm now thinking it might be better to only propagate the event if the callback returns true, for example.

@rysilva
Copy link
Author

rysilva commented Feb 1, 2016

Is there a way to limit dnd-selected callback to only that specific draggable item without silencing click events? Maybe by looking for the click target's closest dnd-item?

@marceljuenemann
Copy link
Owner

Good idea actually, we can just set a property on the event object so that other handler along the way will know that we handled it already.

@marceljuenemann marceljuenemann modified the milestones: 2.0.0, 1.4.0 Feb 1, 2016
@marceljuenemann marceljuenemann modified the milestones: 2.0.0, 2.1.0, 2.x Dec 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants