Fix browser usage by removing BOMs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers dislike \ufeff showing up in the middle of a script, which happens when we bundle with browserify. So we remove all BOMs in this project. Related: browserify/browserify#313
`Changeset.prototype.apply` had a comment incorrectly copied from `Operation.invert`. Fix this, and also change the parameter name to `text` to match the operation `apply` methods.
marcelklehr
added a commit
that referenced
this pull request
Jun 11, 2013
Fix browser usage by removing BOMs
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this project!
Your files begin with a Unicode BOM, which Node has no trouble with. However, when browserify mashes all the files together for
client-side.js, the BOMs end up in the middle of the file, and my browsers choke.Apparently this has been noticed, but not yet fixed, by browserify folks: browserify/browserify#313
I removed the BOMs, and also cleaned up things around
Changeset.prototype.apply. I hope this is useful.