Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The character ',' in the bookmark folder name must be escaped in the tag name #71

Closed
mnsold opened this issue Apr 4, 2018 · 3 comments
Labels

Comments

@mnsold
Copy link

mnsold commented Apr 4, 2018

Software versions

  • Browser: Firefox 59.0.2
  • Nextcloud: 13.0.1
  • Nextcloud Bookmarks app: 0.11.0
  • Floccus: 2.0.5

Steps to reproduce

  1. Create a folder "Example folder, other words" in the bookmarks menu
  2. Add 2 bookmarks to this folder
  3. Specify the synchronization folder in the settings of the Floccus extension in the browser: // Menu of bookmarks
  4. Synchronize your bookmarks
  5. Go to nextcloud, your bookmarks will be tagged with two tags: the first tag is "floccus:> Example folder" and the second tag is "other words"
  6. Delete the account in the settings of the Floccus extension in the browser
  7. Delete your bookmarks in the browser
  8. Add an account in the settings of the Floccus extension in the browser. You should see: Last synchronization: never
  9. Specify the synchronization folder in the settings of the Floccus extension in the browser: // Menu of bookmarks
  10. Synchronize your bookmarks
  11. The folder "Example folder, other words" will be restored as "Example folder" (no words after the comma)

Expected outcome

The folder "Example folder, other words" should be restored with the same name.

Actual outcome

The folder "Example folder, other words" was restored as "Example folder" (without words after the comma)

@marcelklehr
Copy link
Member

Thanks for reporting this!
I can confirm the problem. Nextcloud bookmarks probably should not accept tags with commas in them, or alternatively escape them in some fashion. I'll add a quick fix to floccus until this is resolved in nextcloud.

@marcelklehr
Copy link
Member

Should be fixed in the latest release.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants