Added default values for error.error and error.message #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,8 +140,8 @@ public function setHeaders($raw_headers) { | |||
| public function interpretResponse($json_struct) { | |||
| //server error? | |||
| if(($error = self::interpretError($this->spec, $json_struct, $this->id)) !== FALSE) { | |||
| $this->error = $error['error']['code']; | |||
| $this->errorMessage = $error['error']['message']; | |||
| $this->error = (isset($error['error']['error'])) ? $error['error']['code'] : 'error'; | |||
There was a problem hiding this comment.
I think, you mean "code" here:
$this->error = (isset($error['error']['code'])) ? $error['error']['code'] : 'error';
|
I'm against this - http://www.jsonrpc.org/specification#error_object states clearly that response has to have these properties. If Go extension doesn't return it, it's Go extension error. |
|
Well its a go's standard library implementation. It uses 1.0 spec, and I cannot find anything about error object there: http://json-rpc.org/wiki/specification |
|
Hmm, this PR is included in the other PR as well. As I commented there, But, since 1.0 does not specify the content of the error member, perhaps it is better to not try to extract code, message and data, but just give access to the error as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tivoka used with http://golang.org/pkg/net/rpc/jsonrpc/ there is no "error" or "message" in server response, so we get and undefined index exception. Fixed it by providing some default values.