Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title bar buttons broken #21

Open
CherryDT opened this issue Feb 6, 2022 · 2 comments
Open

Title bar buttons broken #21

CherryDT opened this issue Feb 6, 2022 · 2 comments

Comments

@CherryDT
Copy link

CherryDT commented Feb 6, 2022

Clicking the minimize/maximize/close buttons in the title bar does nothing:

image

v0.2.2
Windows 10 21H1

@CherryDT
Copy link
Author

CherryDT commented Feb 6, 2022

Hm I noticed this doesn't even show the buttons in their pressed state while clicking - but dragging the titlebar (and also right-clicking it for sysmenu and double-clicking it to maximize/restore) still works, so my assumption is that while you can draw this area, you are not receiving any mouse input on it, as Windows is receiving it instead. (In Windows, these are in fact different window messages - WM_NCMOUSEMOVE, WM_NCCLICK, etc. instead of WM_MOUSEMOVE, WM_CLICK etc. - and there is WM_NCHITTEST that can be used to override what "thing" a certain part of a window counts as.) I don't know how Electron handles/exposes these things, but I think it is somehow possible to handle it properly because VSCode does it to, for instance.

@marcello3d
Copy link
Owner

ya I seem to remember this bug when I was testing on Windows and didn't find an obvious way to fix it. The issue is I'm custom rendering the titlebar for the windows 98 visual style, but I'm setting some property incorrectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants