Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glob & npm 5 support #9

Merged
merged 11 commits into from
Sep 3, 2017
Merged

Update glob & npm 5 support #9

merged 11 commits into from
Sep 3, 2017

Conversation

Ilshidur
Copy link
Contributor

@Ilshidur Ilshidur commented Aug 4, 2017

Changes :

I did not upgrade all the dependencies because some had breaking changes and I did not have the time to fix this. I may do this later tho'.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.718% when pulling 7e72c52 on Ilshidur:master into 9cb0e10 on marcells:master.

@marcells
Copy link
Owner

marcells commented Aug 5, 2017

I fixed the issue with the node version on travis. But now there are many jslint issues and a failing test, which can be reproduced locally. Maybe you can take a look at it. You can run the ci stuff with grunt ci.

@Ilshidur
Copy link
Contributor Author

Ilshidur commented Aug 5, 2017

Ok, thanks ! I will do it as soon as I have enough time for it.

@marcells
Copy link
Owner

marcells commented Aug 6, 2017

Thank you!

@Ilshidur
Copy link
Contributor Author

Ilshidur commented Aug 7, 2017

Some linting issues seem weird. Although I'd recommend to move to ESLint instead of JSLint.

@marcells
Copy link
Owner

marcells commented Aug 8, 2017

Thanks for your effort. I will take a look at it this week and maybe replace JSLint.

@marcells marcells merged commit ef18da1 into marcells:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is vulnerable to DoS
3 participants