Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GitLab support #42

Merged
merged 2 commits into from
Mar 20, 2017
Merged

Fixed GitLab support #42

merged 2 commits into from
Mar 20, 2017

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Mar 19, 2017

I started digging through code, b/c by default GitLab integration doesn't work for me, in the log I saw only that parser detect 0 projects.

OFC it's a first step, b/c there is a lot more work to do, i.e. I'd remove async lib, b/c it doesn't work as expected. I tried to follow docs and even simplest things like callback params work in a different way, i.e. I got boolean instead of an array with data 🤷‍♂️

Are you interested in this type of changes or should I just maintain an own fork with custom version?

PS. Tests are failing, b/c I used few ES6 features.

@marcells
Copy link
Owner

Thanks. I'll take a look at it tomorrow.

@marcells marcells merged commit 3f501b7 into marcells:master Mar 20, 2017
@marcells
Copy link
Owner

Thank's for your pull request. I've fixed the es6 issues. If someone has issues with your changes then it would be great if you could take a look at it.

@Igloczek
Copy link
Contributor Author

Thanks! For sure I'll continue work on GitLab integration, b/c my company is using it and for sure this code need some love 😄

Next step will be related to displaying latest builds, not project with the latest build, b/c right now we can't check the status of running in parallel pipelines. I checked how your demo works it looks like just a bug, not feature 😉

@Igloczek Igloczek deleted the gitlab-support branch March 21, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants