Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added numberOfPipelinesPerProject option to GitLab service config #75

Conversation

ntamas
Copy link
Contributor

@ntamas ntamas commented Oct 3, 2017

This pull request adds a new configuration option called numberOfPipelinesPerProject to the GitLab service config, allowing the user to specify the maximum number of pipelines (builds) to fetch for a single project.

This will allow users to select a group of repositories (e.g., all repositories that are owned by the user corresponding to the key that the GitLab API is called with) and specify that the build monitor should show only X builds per project. When the builds are sorted by IDs (which is the case right now), this ensures that only the most recent X builds appear on the CI display. In our case, we use it with X=1 to show only the most recent build for a group of repositories being monitored.

@marcells
Copy link
Owner

marcells commented Oct 3, 2017

Thanks for you PR! It will fix issue #64. But could you please extend the README.md with the new flag?

@ntamas
Copy link
Contributor Author

ntamas commented Oct 3, 2017

Here it is. Actually, since the name of the option is significantly longer than the rest, it might be a good idea to shorten the name of the option. Feel free to propose a new name if needed.

@marcells
Copy link
Owner

marcells commented Oct 3, 2017

Thank you! I like expressive names. ;-)

@marcells marcells merged commit 9ff175b into marcells:master Oct 3, 2017
@ntamas ntamas deleted the feature/gitlab-max-pipelines-per-project branch October 3, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants