Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

[Logger] Define output #23

Closed
marceloboeira opened this issue Aug 20, 2016 · 5 comments
Closed

[Logger] Define output #23

marceloboeira opened this issue Aug 20, 2016 · 5 comments
Assignees
Milestone

Comments

@marceloboeira
Copy link
Owner

Currently the logger is hardcode to the STDOUT, which may be not a very good option for every user, what about defining this in the CLI?

e.g.: bojack server --log ./shared/logs/bojack.log

BoJack would have to create a new file, with the given prefix and add a timestamp:

e.g.: ./shared/logs/bojack_201609201010.log

@marceloboeira marceloboeira added this to the v0.1.1 milestone Aug 20, 2016
@marceloboeira marceloboeira changed the title [Logger] Define output [Logger] Define output Aug 20, 2016
@hugoabonizio
Copy link
Collaborator

@marceloboeira what 201609201010 is suposed to be? 2016-09-20 10:10?

@hugoabonizio hugoabonizio self-assigned this Aug 24, 2016
@marceloboeira
Copy link
Owner Author

@hugoabonizio ahaha something like it, doesn't have to be a different file for each, but I would recommend that instead of opening old files and writing over it...

@hugoabonizio
Copy link
Collaborator

@marceloboeira OK! I add seconds to the timestamp too. Check #35 if it is the expected behavior.

@marceloboeira
Copy link
Owner Author

@hugoabonizio seems OK, we just have to create at somepoint an abstraction to logger so we can implement and test this kind of stuff, otherwise cli.cr is going to be huge and buggy.

@hugoabonizio
Copy link
Collaborator

@marceloboeira you're right!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants