RSpec sane defaults #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable monkey patching and run specs in random order
FooCalculator calculate method was leaking from another test; this commit removes the calculate method in order to properly test raising an exception for classes that dont implement calculate.
|
👍 |
The re-declaration of the class inside the "before" block was causing the test to fail for a specific order, if the method was already defined or not, it could cause an error. Now, every context uses its own class, avoind the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates RSpec configuration to disable monkey patching and runs the specs in random order
Note Interesting thing I found was that classes defined in before blocks leak into other tests; so had to remove_method calculate in order to make the tests pass