Exit with non-zero exit code on exception

[johan-ronnkvist]

Intent: Resolve issue #898

How:

Ensure that when the return value of Service_Run() is less than zero, we exit the service with an exit code of -1. This is done without setting the SERVICE_STOPPED state to indicate that this was not an intentional stop.

According to the Windows API documentation, this is the expectation from the system.

A service is considered failed when it terminates without reporting a status of SERVICE_STOPPED to the service controller.
Source

Why:

Enable services to communicate internal failures, so that an automatic restart policy can be applied.

Testing:

Testing has been done in a pair-dev setup with @TechnicalPirate.

[marcelotduarte]

Compiler error:

"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\bin\HostX86\x86\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\runneradmin\AppData\Local\Temp\build-env-e99xypbk\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\pythonx86.3.7.9\tools\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\pythonx86.3.7.9\tools\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\ATLMFC\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /Tcsource/bases/Win32Service.c /Fobuild\temp.win32-cpython-37\Release\source/bases/Win32Service.obj
  Win32Service.c
  source/bases/Win32Service.c(87): error C2143: syntax error: missing ')' before '='
  source/bases/Win32Service.c(87): error C2072: 'Service_SetStatus': initialization of a function
  source/bases/Win32Service.c(87): error C2059: syntax error: ')'
  source/bases/Win32Service.c(88): error C2143: syntax error: missing ';' before '{'
  source/bases/Win32Service.c(88): error C2449: found '{' at file scope (missing function header?)
  source/bases/Win32Service.c(110): error C2059: syntax error: '}'
  source/bases/Win32Service.c(212): warning C4013: 'Service_Stop' undefined; assuming extern returning int
  source/bases/Win32Service.c(283): error C2198: 'Service_SetStatus': too few arguments for call
  source/bases/Win32Service.c(552): error C2198: 'Service_SetStatus': too few arguments for call
  source/bases/Win32Service.c(613): error C2198: 'Service_SetStatus': too few arguments for call

[marcelotduarte]

Thanks!