Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bdist_rpm should generate only binaries [linux] #1945

Merged
merged 2 commits into from Jul 4, 2023
Merged

Conversation

marcelotduarte
Copy link
Owner

cx_Freeze generates executables for distribution, so it doesn't justify distributing source code. So I removed those parts, getting a code a little easier to maintain.
Added tests.
With this cleanup, it was possible to resolve some small bugs:

  • only packages could be build to executables (now a simple or a complex package can be build) and distributed to rpm.
  • pytest failed because a bug related to script_name
  • long description cannot be empty/none (now it get the same as description).

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (7417928) 55.76% compared to head (3e82969) 55.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   55.76%   55.88%   +0.11%     
==========================================
  Files          55       55              
  Lines        5441     5408      -33     
==========================================
- Hits         3034     3022      -12     
+ Misses       2407     2386      -21     
Impacted Files Coverage Δ
cx_Freeze/command/bdist_rpm.py 86.45% <100.00%> (+5.82%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcelotduarte marcelotduarte merged commit 0888211 into main Jul 4, 2023
21 checks passed
@marcelotduarte marcelotduarte deleted the rpm branch July 4, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant