Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: PySide2/6 - shiboken2/6 in zip_include_packages #1970

Merged
merged 2 commits into from Jul 18, 2023
Merged

Conversation

marcelotduarte
Copy link
Owner

@marcelotduarte marcelotduarte commented Jul 17, 2023

Fixes #1673
Fixes #1679

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 9.52% and project coverage change: +0.08 🎉

Comparison is base (90c1020) 57.50% compared to head (39b0b64) 57.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   57.50%   57.59%   +0.08%     
==========================================
  Files          58       58              
  Lines        5448     5464      +16     
==========================================
+ Hits         3133     3147      +14     
- Misses       2315     2317       +2     
Impacted Files Coverage Δ
cx_Freeze/hooks/pyside6/__init__.py 63.79% <8.33%> (-11.72%) ⬇️
cx_Freeze/hooks/pyside2/__init__.py 59.32% <11.11%> (-7.99%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcelotduarte marcelotduarte merged commit 81d9698 into main Jul 18, 2023
21 checks passed
@marcelotduarte marcelotduarte deleted the pyside6 branch July 18, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'shiboken2.shiboken2' Python 3.9 + PySide6 error on start with zip option enabled
1 participant