Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winversioninfo: fix version string and improve coverage/tests #2211

Merged
merged 2 commits into from Jan 22, 2024

Conversation

marcelotduarte
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e88255e) 52.75% compared to head (4cc16b5) 53.40%.

Files Patch % Lines
cx_Freeze/winversioninfo.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
+ Coverage   52.75%   53.40%   +0.64%     
==========================================
  Files          80       80              
  Lines        6214     6219       +5     
==========================================
+ Hits         3278     3321      +43     
+ Misses       2936     2898      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelotduarte marcelotduarte merged commit 256a8d2 into main Jan 22, 2024
21 checks passed
@marcelotduarte marcelotduarte deleted the version branch January 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant