Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigBookApi + API League #318

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

BigBookApi + API League #318

wants to merge 11 commits into from

Conversation

ddsky
Copy link
Contributor

@ddsky ddsky commented Mar 5, 2024

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • The description does not have more than 100 characters
  • The description does not end with punctuation
  • Each table column is padded with one space on either side
  • I have searched the repository for any relevant issues or pull requests
  • Any category I am creating has the minimum requirement of 3 items
  • All changes have been squashed into a single commit

ddsky and others added 7 commits September 14, 2022 19:22
Add World News API
remove trailing period
remove spaces
add bigbookapi.com and apileague.com
@ddsky
Copy link
Contributor Author

ddsky commented Mar 5, 2024

added bigbookapi.com and apileague.com

@marcelscruz
Copy link
Owner

Could you please make sure the README file isn't formatted with your rules, because this adds a lot of diffs.
Also, only the README file should be changed.
Thank you.

@ddsky
Copy link
Contributor Author

ddsky commented Mar 26, 2024

Could you please make sure the README file isn't formatted with your rules, because this adds a lot of diffs. Also, only the README file should be changed. Thank you.

Hi @marcelscruz which formatting is not correct? I have not applied any rules other than copying format from existing entries.

@marcelscruz
Copy link
Owner

marcelscruz commented Apr 1, 2024

Check the diff of README here, you'll see most of the file is re-formatted.
If you have Prettier, I suggest disabling for this codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants