Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache different listings which share same mediatype and action #18

Closed
wants to merge 3 commits into from

Conversation

redglory
Copy link
Contributor

@redglory redglory commented Sep 8, 2017

No description provided.

@marcelveldt
Copy link
Contributor

sorry, I can't agree to this because this will fill up the cache with orphaned listings.
data is stored with a unique key and off course retrieved with that same key.
To have a quick way of telling if the data needs to be refreshed the checksum is used. This will be filled for example with the timestamp the data was last changed (and e.g. updated when there was an item watched or the database updated).

Appending the checksum to the cachekey will fill the cache database with useless entries.

The issue needs to be fixed by making sure the key is correct, in this case the path needs to be appended

@marcelveldt
Copy link
Contributor

I've just fixed the issue in the code so it will be available in next update.

@redglory
Copy link
Contributor Author

"Appending the checksum to the cachekey will fill the cache database with useless entries." - Yupp, was debugging my changes and found it was creating ghost cache strings.

Thanks for the update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants