-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added filter by path and tag to unaired and nextaired methods #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, please see my comments in both PR's (also in tvdb module) before I can accept the merge
resources/lib/episodes.py
Outdated
all_shows = self.metadatautils.kodidb.tvshows(sort=kodi_constants.SORT_LASTPLAYED, filters=filters, | ||
limits=(0, self.options["limit"])) | ||
tvshows_ids = [d['tvshowid'] for d in all_shows] | ||
episodes = self.metadatautils.thetvdb.get_kodi_unaired_episodes(True, tvshows_ids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this line in
episodes = self.metadatautils.thetvdb.get_kodi_unaired_episodes(True, False, tvshows_ids)
see my comments in the PR for tvdb module
resources/lib/episodes.py
Outdated
all_shows = self.metadatautils.kodidb.tvshows(sort=kodi_constants.SORT_LASTPLAYED, filters=filters, | ||
limits=(0, self.options["limit"])) | ||
tvshows_ids = [d['tvshowid'] for d in all_shows] | ||
episodes = self.metadatautils.thetvdb.get_kodi_unaired_episodes(False, tvshows_ids)[:self.options["limit"]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this line in
episodes = self.metadatautils.thetvdb.get_kodi_unaired_episodes(False, False, tvshows_ids)
episodes = episodes[:self.options["limit"]]
see my comments in the PR for tvdb module
You are right! Fixed thetvdb tvshows_ids parameter and made it optional. |
Thanks ! |
Following the change in next episodes which can be filtered by path and tag parameters, I've applied same concept to nextairing and unaired episodes, which relie on the script.module.thetvdb module.
Also added pt_pt full translation .po