Skip to content

Commit

Permalink
Set TrimMode explicitly back to partial for .NET 7 compat (microsoft#…
Browse files Browse the repository at this point in the history 
…1378)

See:

https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options?pivots=dotnet-7-0
  • Loading branch information
@Scottj1s
Scottj1s committed Oct 10, 2023
1 parent f72609f commit c2fd30d
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 0 deletions.
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-arm64-unpackaged.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>ARM64</Platform>
<RuntimeIdentifier>win10-arm64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-arm64.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>ARM64</Platform>
<RuntimeIdentifier>win10-arm64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x64-unpackaged.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x64</Platform>
<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x64.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x64</Platform>
<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x86-unpackaged.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x86</Platform>
<RuntimeIdentifier>win10-x86</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>False</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions WinUIGallery/Properties/PublishProfiles/win10-x86.pubxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PublishProtocol>FileSystem</PublishProtocol>
<Platform>x86</Platform>
<RuntimeIdentifier>win10-x86</RuntimeIdentifier>
<!--NOTE: this refers to .NET (not WinAppSDK) self-containment which must always be true,
since there is no Windows framework package available for .NET 5+ -->
<SelfContained>True</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishAppxPackage>True</PublishAppxPackage>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishTrimmed>$(Optimized)</PublishTrimmed>
<!--With .NET 7, trimming mode default changed from partial to full which is more
aggressive and includes all assemblies, not just those that have explicitly opted
into trimming, causing application errors.-->
<TrimMode>partial</TrimMode>
</PropertyGroup>
</Project>

0 comments on commit c2fd30d

Please sign in to comment.