This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Trust base_url if it starts with https?://
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 7, 2016 16:33
… do not doubt that and try to prepend the protocol; https->http proxies in front of a website may remove the ssl-part for (company) internal http-trafic.
marcgibbons
added a commit
that referenced
this pull request
Oct 16, 2016
Fixes regression as of 2.0.6 which sees customizations added to the Document, but ignored by the codec. This is a quick hack to allow passing in extra OpenAPI spec data until we can find a better solution. (Fixes #561)
marcgibbons
added a commit
that referenced
this pull request
Oct 16, 2016
Fixes regression as of 2.0.6 which sees customizations added to the Document, but ignored by the codec. This is a quick workaround to allow passing in extra OpenAPI spec data until we can find a better solution. (Fixes #561)
|
What I understand is that version 2 is quite different from the first version, so it would be nice if this was also fixed in version 1.* |
|
Sorry, I incorrectly tagged this PR in a commit. Seems ok to me. |
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
base_urlis set to start with https?://, the deployer should know what he is doing, and hence it should not be set doubted by prepending https?:// depending on the original request's protocol.The request protocol might have been altered by a proxy which transfers https to http, making traffic at the server seem http, while the internet sees it as https.