Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovakia is missing from the country list #29

Closed
taggartgorman opened this issue Oct 26, 2022 · 8 comments
Closed

Slovakia is missing from the country list #29

taggartgorman opened this issue Oct 26, 2022 · 8 comments

Comments

@taggartgorman
Copy link

Is this because the iso2 code for Slovakia is the same as the deleted area "Sikkim"?

@hlopetz
Copy link
Contributor

hlopetz commented Oct 26, 2022

just hit that too

@hlopetz
Copy link
Contributor

hlopetz commented Oct 26, 2022

i am not sure about country, but it looks like Sikkim is an Indian state/province. probably, there is a mistake

hlopetz added a commit to hlopetz/node-countries that referenced this issue Oct 26, 2022
hlopetz added a commit to hlopetz/node-countries that referenced this issue Oct 26, 2022
@hlopetz
Copy link
Contributor

hlopetz commented Oct 26, 2022

there is a PR #30 for your convenience. please review

marchah added a commit that referenced this issue Oct 27, 2022
@marchah
Copy link
Owner

marchah commented Oct 28, 2022

published thanks

@marchah marchah closed this as completed Oct 28, 2022
@hlopetz
Copy link
Contributor

hlopetz commented Oct 28, 2022

i am not sure what's wrong, but it still returns null on getCountryByName('Slovakia', true). i might changed the meta-data in a wrong place. please review

@marchah
Copy link
Owner

marchah commented Nov 15, 2022

@hlopetz are you sure the package is the newest version ?

@jhonvedo
Copy link

@marchah same problem
pachage.json

  "dependencies": {   
    "node-countries": "2.1.3",
    "ts-node": "^10.8.0"
  }

and when i use getCountryByName('Slovakia', true) return null

@marchah
Copy link
Owner

marchah commented Nov 16, 2022

Should be fixed now, my fault forgot to run yarn build before pushing the package to npm 😅

Correct version is 2.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants