Fail with exception when decoding invalid image message (#20)

marchof · Oct 12, 2021 · e36aa35 · e36aa35
1 parent 47048cb
commit e36aa35
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/src/main/java/com/mountainminds/three4j/BlobId.java b/src/main/java/com/mountainminds/three4j/BlobId.java
@@ -13,9 +13,6 @@
  *******************************************************************************/
 package com.mountainminds.three4j;
 
-import java.io.IOException;
-import java.io.InputStream;
-
 /**
  * A 16 byte identifier for uploaded blobs.
  */
@@ -46,9 +43,4 @@ public static BlobId of(String hexvalue) {
 		return of(fromHex(hexvalue));
 	}
 
-	static BlobId read(InputStream in) throws IOException {
-		var id = in.readNBytes(SIZE);
-		return id.length == SIZE ? of(id) : null;
-	}
-
 }
diff --git a/src/main/java/com/mountainminds/three4j/Nonce.java b/src/main/java/com/mountainminds/three4j/Nonce.java
@@ -13,9 +13,6 @@
  *******************************************************************************/
 package com.mountainminds.three4j;
 
-import java.io.IOException;
-import java.io.InputStream;
-
 import software.pando.crypto.nacl.Bytes;
 
 /**
@@ -55,9 +52,4 @@ public static Nonce random() {
 		return of(Bytes.secureRandom(SIZE));
 	}
 
-	static Nonce read(InputStream in) throws IOException {
-		var id = in.readNBytes(SIZE);
-		return id.length == SIZE ? of(id) : null;
-	}
-
 }
diff --git a/src/main/java/com/mountainminds/three4j/PlainMessage.java b/src/main/java/com/mountainminds/three4j/PlainMessage.java
@@ -145,9 +145,9 @@ public final static class Image extends PlainMessage {
 		private final Nonce nonce;
 
 		private Image(DataInputStream in) throws IOException {
-			blobId = BlobId.read(in);
+			blobId = BlobId.of(in.readNBytes(BlobId.SIZE));
 			size = in.readInt();
-			nonce = Nonce.read(in);
+			nonce = Nonce.of(in.readNBytes(Nonce.SIZE));
 		}
 
 		public Image(UploadedBlob blob) throws IllegalArgumentException {