Feature/add downcast send #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <neikos@neikos.email>
Signed-off-by: Marcel Müller <neikos@neikos.email>
marcianx
requested changes
Sep 1, 2023
| @@ -194,6 +194,16 @@ impl<T: Any> Downcast for T { | |||
| fn as_any_mut(&mut self) -> &mut dyn Any { self } | |||
| } | |||
|
|
|||
| pub trait DowncastSend: Downcast + Send { | |||
| fn into_any_send(self: Box<Self>) -> Box<dyn Any + Send>; | |||
There was a problem hiding this comment.
It feels a little less elegant that
- This method is not supported for
DowncastSyncgiven that it also includesDowncast + Sendin its constraints. - We're not supporting
into_any_sync. Do you anticipate no need for this?
I suppose we could publish the current change that you've written and then conceivably do both of the above changes and then publish a 2.0 version. I'm not sure how much that's worth it. Thoughts?
There was a problem hiding this comment.
Good catch! In my mind if you wanted a Box<dyn Any + Send> you'd just use DowncastSend and not expect DowncastSync to provide it for you, but I can get why this might be wanted.
I'll investigate if adding the supertrait is a breaking change at all
TheNeikos
force-pushed
the
feature/add_downcast_send
branch
from
9de600a
to
f879afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14