Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no_std #9

Merged
merged 4 commits into from
Jun 28, 2020
Merged

Support no_std #9

merged 4 commits into from
Jun 28, 2020

Conversation

wangrunji0408
Copy link
Contributor

Now feature alloc is available in stable Rust.
It's time to make it no_std compatible.

Similar to PR #5 .

@marcianx
Copy link
Owner

Thank you for contributing!
I'm seeing a bunch of

error[E0433]: failed to resolve: maybe a missing crate `core`?

errors when running tests via cargo test. Could you possibly resolve these?

@marcianx
Copy link
Owner

And just to emphasize, I'd love for this to be fixed without updating the tests themselves to test backward-compatibility.

@wangrunji0408
Copy link
Contributor Author

I realized that my previous implementation was not correct. It will break on std.
So I rewrote it by referring to this guide.
And now it works well for both std and no_std with all tests unchanged.

I also added GitHub Actions to make sure everything is fine. You can check the result here.

@marcianx
Copy link
Owner

Thank, you this is excellent!

@marcianx marcianx merged commit cdccc63 into marcianx:master Jun 28, 2020
@marcianx
Copy link
Owner

marcianx commented Jun 28, 2020

Huh, rebase didn't rebase the common commit properly. I'll fix it offline and force a push. You might have trouble syncing with your branch due to merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants