Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on Spock should be provided #30

Closed
Vampire opened this issue Feb 20, 2023 · 0 comments · Fixed by #31
Closed

Dependency on Spock should be provided #30

Vampire opened this issue Feb 20, 2023 · 0 comments · Fixed by #31

Comments

@Vampire
Copy link
Contributor

Vampire commented Feb 20, 2023

Due to the different variants there are of Spock that are unfortunately expressed via version parts, it is probably not a good idea to depend on one explicitly in the dependencies. Instead it should probabyl be provided, as it anyway does not make sense to include this extension without spock it should be a safe guess that it will be available.
Vampire added a commit to Vampire/spock-subjects-collaborators-extension that referenced this issue Feb 24, 2023
@Vampire
[marcingrzejszczak#30] Clean up unnecessary dependencies
245ecea
@Vampire Vampire mentioned this issue Feb 24, 2023
Merged
marcingrzejszczak added a commit that referenced this issue Mar 1, 2023
@marcingrzejszczak
Merge pull request #31 from Vampire/issue-30
8307ada 
[#30] Clean up unnecessary dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#30] Clean up unnecessary dependencies Vampire/spock-subjects-collaborators-extension
1 participant
@Vampire