-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for GNOME 45 #25
Update for GNOME 45 #25
Conversation
andyholmes
commented
Sep 26, 2023
- chore: bump shell-version to "45"
- feat: add gettext-domain to metadata.json
- refactor: use GLib instead of deprecated Mainloop
- refactor: port extension.js to ESModules
- refactor: port prefs.js to ESModules
This allows GNOME Shell to automatically initialize translations.
The Mainloop import has been deprecated, and is not available with ESModules anyways, so switch to the GLib import.
Switch from legacy `imports` to ESModule's `import` statements, and use `export` instead of `var` for exports.
I tried to touch as little as possible, leaving anything unrelated to the porting process as-is. I also left the version bump to you, but let me know if I missed anything 🙂 |
I downloaded the code for the PR and added it to my system (and renamed the folder), but I got an error message. @andyholmes were you able to get the PR working on your machine? Given that Gnome 45 will not be added anytime in the foreseeable future (#26), it might be advisable to create your own fork and upload it so others on Gnome 45 can use this extension |
Yep, it worked for me. Renaming the folder might have caused problems, since the folder name must match the UUID in |
Yes, I had to rename it to the UUID The settings of extension date-menu-formatter@marcinjakubowski.github.com had an error:
Stack trace:
|
Are you sure it's the version here installed? It works for me: Screencast.from.2023-09-30.16-09-36.webmHere's a ZIP: date-menu-formatter@marcinjakubowski.github.com.shell-extension.zip |
I was getting the same error message after installing using the above zip file. I was just copy-pasting-renaming directories. I then tried to use |
it works for me! thanks! |
I couldn't get the |
One thing I noticed afterwards is that my system wasn't using Gnome 45, so I was so confused as to why the code was working for an older Gnome version. I was unable to download any older versions before. But, I guess, when my extensions app said there was a new version, it downloaded an older version as none of the code uses the new import declarations anymore. But I'm confused as to why I wasn't able to download an older version before. |
Downloaded the zip from #25 (comment) and confirmed as working for me on Gnome 45.1 and Arch synced to the latest repos. |
Working normally for me for weeks. |
Same here. Had the clock freeze once but that's about it, working perfectly otherwise. |