Skip to content

Commit

Permalink
fixed ip restriction tests when runned multiple times.
Browse files Browse the repository at this point in the history
Added sleep to fix cache issues

--HG--
branch : beta
extra : amend_source : d9fd20b957f6d5acc54fe8f28556704c08d5c00b
  • Loading branch information
marcinkuzminski committed Jan 20, 2013
1 parent 9916bff commit 799dfa3
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 25 deletions.
47 changes: 28 additions & 19 deletions rhodecode/tests/scripts/test_vcs_operations.py
Expand Up @@ -29,14 +29,15 @@
import os
import tempfile
import unittest
import time
from os.path import join as jn
from os.path import dirname as dn

from tempfile import _RandomNameSequence
from subprocess import Popen, PIPE

from rhodecode.tests import *
from rhodecode.model.db import User, Repository, UserLog
from rhodecode.model.db import User, Repository, UserLog, UserIpMap
from rhodecode.model.meta import Session
from rhodecode.model.repo import RepoModel
from rhodecode.model.user import UserModel
Expand Down Expand Up @@ -424,17 +425,21 @@ def test_push_unlocks_repository_hg(self):

def test_ip_restriction_hg(self):
user_model = UserModel()
new_ip = user_model.add_extra_ip(TEST_USER_ADMIN_LOGIN, '10.10.10.10/32')
Session().commit()
try:
user_model.add_extra_ip(TEST_USER_ADMIN_LOGIN, '10.10.10.10/32')
Session().commit()
clone_url = _construct_url(HG_REPO)
stdout, stderr = Command('/tmp').execute('hg clone', clone_url)
assert 'abort: HTTP Error 403: Forbidden' in stderr
finally:
#release IP restrictions
for ip in UserIpMap.getAll():
UserIpMap.delete(ip.ip_id)
Session().commit()

time.sleep(2)
clone_url = _construct_url(HG_REPO)
stdout, stderr = Command('/tmp').execute('hg clone', clone_url)
assert 'abort: HTTP Error 403: Forbidden' in stderr

#release IP restrictions
clone_url = _construct_url(HG_REPO)
user_model.delete_extra_ip(TEST_USER_ADMIN_LOGIN, new_ip.ip_id)
Session().commit()
stdout, stderr = Command('/tmp').execute('hg clone', clone_url)

assert 'requesting all changes' in stdout
assert 'adding changesets' in stdout
Expand All @@ -445,17 +450,21 @@ def test_ip_restriction_hg(self):

def test_ip_restriction_git(self):
user_model = UserModel()
new_ip = user_model.add_extra_ip(TEST_USER_ADMIN_LOGIN, '10.10.10.10/32')
Session().commit()
try:
user_model.add_extra_ip(TEST_USER_ADMIN_LOGIN, '10.10.10.10/32')
Session().commit()
clone_url = _construct_url(GIT_REPO)
stdout, stderr = Command('/tmp').execute('git clone', clone_url)
assert 'error: The requested URL returned error: 403 Forbidden' in stderr
finally:
#release IP restrictions
for ip in UserIpMap.getAll():
UserIpMap.delete(ip.ip_id)
Session().commit()

time.sleep(2)
clone_url = _construct_url(GIT_REPO)
stdout, stderr = Command('/tmp').execute('git clone', clone_url)
assert 'error: The requested URL returned error: 403 Forbidden' in stderr

#release IP restrictions
clone_url = _construct_url(GIT_REPO)
user_model.delete_extra_ip(TEST_USER_ADMIN_LOGIN, new_ip.ip_id)
Session().commit()
stdout, stderr = Command('/tmp').execute('git clone', clone_url)

assert 'Cloning into' in stdout
assert stderr == ''
12 changes: 6 additions & 6 deletions test.ini
Expand Up @@ -30,16 +30,16 @@ pdebug = false

[server:main]
##nr of threads to spawn
#threadpool_workers = 5
threadpool_workers = 5

##max request before thread respawn
#threadpool_max_requests = 2
threadpool_max_requests = 2

##option to use threads of process
#use_threadpool = true
use_threadpool = true

#use = egg:Paste#http
use = egg:waitress#main
use = egg:Paste#http
#use = egg:waitress#main
host = 127.0.0.1
port = 5000

Expand Down Expand Up @@ -295,4 +295,4 @@ datefmt = %Y-%m-%d %H:%M:%S
[formatter_color_formatter]
class=rhodecode.lib.colored_formatter.ColorFormatter
format= %(asctime)s.%(msecs)03d %(levelname)-5.5s [%(name)s] %(message)s
datefmt = %Y-%m-%d %H:%M:%S
datefmt = %Y-%m-%d %H:%M:%S

0 comments on commit 799dfa3

Please sign in to comment.