Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HACK: gs_usb: add termination support #9

Closed
wants to merge 1 commit into from
Closed

HACK: gs_usb: add termination support #9

wants to merge 1 commit into from

Conversation

marckleinebudde
Copy link
Owner

@marckleinebudde
Copy link
Owner Author

See my take on the Linux driver:

https://lore.kernel.org/all/20220918202348.675850-1-mkl@pengutronix.de/

@marckleinebudde marckleinebudde mentioned this pull request Sep 18, 2022
Closed
@Daniel-Trevitz
Copy link

Looks good. Reworking candlelight to match

@Daniel-Trevitz
Copy link

gs_usb_get_termination does not use the term parameter.

@marckleinebudde
Copy link
Owner Author

gs_usb_get_termination does not use the term parameter.

noticed that, working on a v2

@marckleinebudde
Copy link
Owner Author

marckleinebudde commented Sep 18, 2022 •
edited
Loading

Here's the v2 https://lore.kernel.org/all/20220918211802.692405-1-mkl@pengutronix.de. Added some error handling cleanups. The patch series applies to current https://github.com/torvalds/linux/tree/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-Trevitz Daniel-Trevitz Daniel-Trevitz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marckleinebudde @Daniel-Trevitz