Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit test for the 'balance' function in utils.py #69

Closed
Shashi456 opened this issue Feb 19, 2018 · 2 comments
Closed

Write unit test for the 'balance' function in utils.py #69

Shashi456 opened this issue Feb 19, 2018 · 2 comments
Labels
good first issue testing

Comments

@Shashi456
Copy link
Contributor

Shashi456 commented Feb 19, 2018 •
edited by marco-c
Loading

A unit test has to be written for the balance function in utils.py.

See also PR #63.
@marco-c marco-c changed the title Writing Unit test for Balance function in Utils.py Write unit test for the 'balance' function in utils.py Feb 19, 2018
@adbugger
Copy link
Contributor

adbugger commented Mar 3, 2018

Hi, is it ok to take this issue and work on it?

@marco-c
Copy link
Owner

marco-c commented Mar 3, 2018

Sure!

adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 4, 2018
@adbugger
Added test case for 'balance' function in utils.py for issue marco-c#69
a950a82
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 4, 2018
@adbugger
Added test case for 'balance' function in utils.py for issue marco-c#69
fd6b0d0
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 4, 2018
@adbugger
Added unit test for 'balance' function (marco-c#69)
7f6b72c
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 4, 2018
@adbugger
Asserted number of iterations. Test failing. (marco-c#69)
9e9deb3
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 5, 2018
@adbugger
Explicit checking of returned items. Test failing marco-c#69
b057eef
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 5, 2018
@adbugger
Added test case where data cannot be balanced. This test passes. (mar…
822f393 
…co-c#69)
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 5, 2018
@adbugger
Changed test case to maintain relative order for same label items. (m…
fc2b3a2 
…arco-c#69)
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 5, 2018
@adbugger
Modified test cases for now. All pass. Will fix function and test cas…
46f3b10 
…es in another PR. (marco-c#69)
adbugger added a commit to adbugger/autowebcompat that referenced this issue Mar 5, 2018
@adbugger
Modified test cases for now. All pass. Will fix function and test cas…
1c799ef 
…es in another PR. (marco-c#69)
This was referenced Mar 5, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marco-c @adbugger @Shashi456