Skip to content

Commit

Permalink
Bug 1454205 [wpt PR 10477] - Accept two values in the overflow shorth…
Browse files Browse the repository at this point in the history
…and, a=testonly

Automatic update from web-platform-testsAccept two values in the overflow shorthand

w3c/csswg-drafts#2484 details the resolution
by the CSSWG to accept two values in the overflow shorthand. Update our
implementation to match this, and also update two existing CSSOM
serialization tests. Additionally remove tests that are duplicates of
those currently found in WPT.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4qF8XPQ1z2s

Bug: 833105
Change-Id: Id8f61182a7d7369a2f575acfdbf608600d1218dd
Reviewed-on: https://chromium-review.googlesource.com/1013618
Commit-Queue: Chris Nardi <cnardichromium.org>
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#554078}

--

wpt-commits: e6756de059f68d445306ac35a6b8e80633d75925
wpt-pr: 10477

UltraBlame original commit: 22226423b006da14b61e173f36b6e228880d04db
  • Loading branch information
marco-c committed Oct 3, 2019
1 parent 9610714 commit c91912c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 33 deletions.
4 changes: 2 additions & 2 deletions testing/web-platform/meta/MANIFEST.json
Original file line number Diff line number Diff line change
Expand Up @@ -3573924,7 +3573924,7 @@ html
:
[
"
48ca70f4c20da103276e1b053ca0e4613fcc2819
85952fbd040de03f5082f28ba8116fd4827a1fc3
"
"
testharness
Expand Down Expand Up @@ -3574168,7 +3574168,7 @@ html
:
[
"
8bfc0dff5da1859e17df31ceeca710d17a982109
9211674fd69ddfa32d3bafcf2bc967977eb3ec31
"
"
testharness
Expand Down
36 changes: 12 additions & 24 deletions testing/web-platform/tests/css/cssom/overflow-serialization.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,9 @@
>
CSSOM
-
Overlow
property
has
different
Overflow
shorthand
serialization
than
other
shorthands
.
<
/
title
Expand Down Expand Up @@ -156,13 +150,13 @@
-
x
:
inherit
scroll
;
overflow
-
y
:
unset
hidden
;
}
<
Expand Down Expand Up @@ -350,16 +344,9 @@
cssText
"
overflow
-
x
:
inherit
;
overflow
-
y
:
unset
scroll
hidden
;
"
"
Expand Down Expand Up @@ -583,7 +570,7 @@
overflowX
=
"
inherit
scroll
"
;
div
Expand All @@ -593,7 +580,7 @@
overflowY
=
"
unset
hidden
"
;
assert_equals
Expand All @@ -604,6 +591,8 @@
.
overflow
"
scroll
hidden
"
"
Overflow
Expand All @@ -615,10 +604,9 @@
with
different
keywords
shouldn
'
t
should
serialize
correctly
.
"
)
Expand Down
7 changes: 0 additions & 7 deletions testing/web-platform/tests/css/cssom/shorthand-values.html
Original file line number Diff line number Diff line change
Expand Up @@ -525,15 +525,8 @@
:
'
overflow
-
x
:
scroll
;
overflow
-
y
:
hidden
;
'
Expand Down

0 comments on commit c91912c

Please sign in to comment.