Skip to content

Commit

Permalink
Bug 1679943 [wpt PR 26094] - web-nfc: Merge NDEFWriter in NDEFReader,…
Browse files Browse the repository at this point in the history
… a=testonly

Automatic update from web-platform-tests
web-nfc: Merge NDEFWriter in NDEFReader

NDEFWriter and NDEFReader share a lot of similar
features and a writing device, will also read.

Therefore it was decided to simplify NDEF functionality,
and to have only one class called NDEFReader,
which can read and write.

refers to w3c/web-nfc#601

Because kWebNfcNdefReaderScan and kWebNfcNdefWriterWrite are now
used in idl extended attributes, their usages
may be higher now as they were fired after user granted permission.

Bug: 1131141
Change-Id: I8cc2ce053e5bb43c0fa5b299bdaf5cb5317bf859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424208
Reviewed-by: Kentaro Hara <harakenchromium.org>
Reviewed-by: Reilly Grant <reillygchromium.org>
Reviewed-by: François Beaufort <beaufort.francoisgmail.com>
Commit-Queue: François Beaufort <beaufort.francoisgmail.com>
Cr-Commit-Position: refs/heads/master{#832236}

--

wpt-commits: 77f3f1533681dedef98a4c94c2abdb562d097002
wpt-pr: 26094

UltraBlame original commit: ecf56f63bb2558df400ac93be88c868c81595f25
  • Loading branch information
marco-c committed Dec 14, 2020
1 parent 551f23f commit 5655d81
Show file tree
Hide file tree
Showing 7 changed files with 475 additions and 297 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,15 @@
>
{
const
reader
ndef
=
new
NDEFReader
(
)
;
const
readerWatcher
ndefWatcher
=
new
EventWatcher
Expand Down Expand Up @@ -174,7 +174,7 @@
=
>
{
readerWatcher
ndefWatcher
.
wait_for
(
Expand Down Expand Up @@ -211,7 +211,7 @@
)
;
await
reader
ndef
.
scan
(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<
title
>
NDEFWriter
NDEFReader
.
write
respect
Expand Down Expand Up @@ -136,7 +136,7 @@
writer
=
new
NDEFWriter
NDEFReader
(
)
;
Expand Down Expand Up @@ -204,13 +204,13 @@
}
"
Test
NDEFWriter
NDEFReader
.
write
operation
should
be
suspend
suspended
when
document
is
Expand Down
Loading

0 comments on commit 5655d81

Please sign in to comment.