Skip to content

Commit

Permalink
Bug 1858227 [wpt PR 42068] - selectlist: Implement new keyboard behav…
Browse files Browse the repository at this point in the history
…ior, a=testonly

Automatic update from web-platform-tests
selectlist: Implement new keyboard behavior

This patch implements several keyboard behaviors:
- Enter while the listbox is closed should not open the listbox and
  should instead submit the form.
- Enter while the listbox is open should select/commit the currently
  focused option and close the listbox.
- Space should open the listbox.
- Arrow keys while the listbox is open should not commit the newly
  focused value.
- Arrow keys while the listbox is closed should open the listbox.

These were resolved on in OpenUI here:
- openui/open-ui#433 (comment)
- openui/open-ui#386 (comment)
- openui/open-ui#742

This patch also implements the resolution here to stop changing the
visible value of the selected option while the user is switching the
focused option using the arrow keys:

Fixed: 1422275
Change-Id: If5e7328ad739f9c7339dcd17561c57875d4255e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876791
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Mason Freed <masonfchromium.org>
Cr-Commit-Position: refs/heads/main{#1207785}

--

wpt-commits: 020d2129c354423b490e1447f13463829ab92bc0
wpt-pr: 42068

UltraBlame original commit: ffe5b326db40e78be875dcaa486226af32ff2110
  • Loading branch information
marco-c committed Oct 30, 2023
1 parent c43081f commit a71ebad
Show file tree
Hide file tree
Showing 3 changed files with 1,990 additions and 293 deletions.
Loading

0 comments on commit a71ebad

Please sign in to comment.