Skip to content

Commit

Permalink
Bug 1793070 [wpt PR 36108] - Add constraint space flag for being push…
Browse files Browse the repository at this point in the history
…ed by floats., a=testonly

Automatic update from web-platform-tests
Add constraint space flag for being pushed by floats.

When clearance has already been applied in a previous layout pass (along
with resolving the BFC block-offset) that aborted, or if we apply
clearance before entering child layout at all, we won't be able to
detect this during child layout, since the BFC block-offset has already
been pushed down in the constraint space. We therefore need a flag. This
allows us to correctly identify class C breakpoints [1].

[1] https://www.w3.org/TR/css-break-3/#possible-breaks

Set this flag before entering layout when we have pre-applied clearance.
There are two different locations that do this. Added one test for each.

Bug: 1366263
Change-Id: I84e4c01276fe035720cdc7e6d626fcfaf247f414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921635
Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org>
Commit-Queue: Morten Stenshorne <mstenshochromium.org>
Cr-Commit-Position: refs/heads/main{#1053208}

--

wpt-commits: e215f48ec622a89e2306ff3276c918ae58d6516d
wpt-pr: 36108

UltraBlame original commit: 784d98fa18f8a8f6a019080cc036638e196683a2
  • Loading branch information
marco-c committed Apr 20, 2023
1 parent 257e6af commit a77d73f
Show file tree
Hide file tree
Showing 2 changed files with 554 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,294 @@
<
!
DOCTYPE
html
>
<
link
rel
=
"
author
"
title
=
"
Morten
Stenshorne
"
href
=
"
mailto
:
mstensho
chromium
.
org
"
>
<
link
rel
=
"
help
"
href
=
"
https
:
/
/
www
.
w3
.
org
/
TR
/
css
-
break
-
3
/
#
possible
-
breaks
"
>
<
link
rel
=
"
match
"
href
=
"
.
.
/
reference
/
ref
-
filled
-
green
-
100px
-
square
.
xht
"
>
<
p
>
Test
passes
if
there
is
a
filled
green
square
and
<
strong
>
no
red
<
/
strong
>
.
<
/
p
>
<
div
style
=
"
columns
:
2
;
column
-
fill
:
auto
;
column
-
gap
:
0
;
width
:
100px
;
height
:
100px
;
background
:
red
;
"
>
<
div
style
=
"
height
:
50px
;
background
:
green
;
"
>
<
/
div
>
<
div
>
<
div
style
=
"
float
:
left
;
width
:
100
%
;
height
:
50px
;
background
:
green
;
"
>
<
/
div
>
<
div
style
=
"
break
-
inside
:
avoid
;
clear
:
left
;
"
>
<
div
style
=
"
float
:
left
;
width
:
100
%
;
height
:
10px
;
background
:
green
;
"
>
<
/
div
>
<
div
style
=
"
height
:
10px
;
"
>
<
/
div
>
<
div
style
=
"
height
:
90px
;
background
:
green
;
"
>
<
/
div
>
<
/
div
>
<
/
div
>
<
/
div
>
Loading

0 comments on commit a77d73f

Please sign in to comment.