Skip to content

Commit

Permalink
Bug 1547179 - Remove an assertion that's no longer valid because rt->…
Browse files Browse the repository at this point in the history
…profilingScripts no longer implies IsLCovEnabled. r=nbp

Differential Revision: https://phabricator.services.mozilla.com/D28952

--HG--
extra : moz-landing-system : lando
  • Loading branch information
jandem committed May 3, 2019
1 parent cc7e371 commit 0ef93c5
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions js/src/vm/Realm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -338,12 +338,10 @@ void Realm::traceRoots(JSTracer* trc,
// keys of the HashMap to avoid adding a strong reference to the JSScript
// pointers.
//
// If the code coverage is either enabled with the --dump-bytecode command
// line option, or with the PCCount JSFriend API functions, then we mark the
// keys of the map to hold the JSScript alive.
// If the --dump-bytecode command line option or the PCCount JSFriend API
// is used, then we mark the keys of the map to hold the JSScript alive.
if (scriptCountsMap && trc->runtime()->profilingScripts &&
!JS::RuntimeHeapIsMinorCollecting()) {
MOZ_ASSERT_IF(!trc->runtime()->isBeingDestroyed(), collectCoverage());
for (ScriptCountsMap::Range r = scriptCountsMap->all(); !r.empty();
r.popFront()) {
JSScript* script = const_cast<JSScript*>(r.front().key());
Expand Down

0 comments on commit 0ef93c5

Please sign in to comment.