Backed out 8 changesets (bug 1513937, bug 1546310, bug 1548788, bug 1…

…547688, bug 1547452, bug 1540777, bug 1542669, bug 1547454) for causing bug 1549362. Backed out changeset 8dca7df29492 (bug 1548788) Backed out changeset 688f361e8bb6 (bug 1547688) Backed out changeset b5d8d57838a3 (bug 1540777) Backed out changeset d1bd31177b14 (bug 1513937) Backed out changeset df97dfbb526a (bug 1546310) Backed out changeset ade08d6dc361 (bug 1547454) Backed out changeset b622431054b7 (bug 1547452) Backed out changeset ad73e5604411 (bug 1542669)
marco-c · May 6, 2019 · 4f044a2 · 4f044a2
1 parent 0b3e867
commit 4f044a2
Show file tree

Hide file tree

Showing 27 changed files with 387 additions and 1,536 deletions.
diff --git a/dom/cache/Context.cpp b/dom/cache/Context.cpp
@@ -389,7 +389,8 @@ Context::QuotaInitRunnable::Run() {
       MOZ_DIAGNOSTIC_ASSERT(qm);
       nsresult rv = qm->EnsureOriginIsInitialized(
           PERSISTENCE_TYPE_DEFAULT, mQuotaInfo.mSuffix, mQuotaInfo.mGroup,
-          mQuotaInfo.mOrigin, getter_AddRefs(mQuotaInfo.mDir));
+          mQuotaInfo.mOrigin,
+          /* aCreateIfNotExists */ true, getter_AddRefs(mQuotaInfo.mDir));
       if (NS_FAILED(rv)) {
         resolver->Resolve(rv);
         break;

diff --git a/dom/indexedDB/ActorsParent.cpp b/dom/indexedDB/ActorsParent.cpp
@@ -17159,7 +17159,8 @@ nsresult Maintenance::DirectoryWork() {
         // Ensure origin is initialized first. It will initialize all origins
         // for temporary storage including IDB origins.
         rv = quotaManager->EnsureOriginIsInitialized(
-            persistenceType, suffix, group, origin, getter_AddRefs(directory));
+            persistenceType, suffix, group, origin,
+            /* aCreateIfNotExists */ true, getter_AddRefs(directory));
 
         if (NS_WARN_IF(NS_FAILED(rv))) {
           return rv;
@@ -19868,7 +19869,8 @@ nsresult OpenDatabaseOp::DoDatabaseWork() {
   nsCOMPtr<nsIFile> dbDirectory;
 
   nsresult rv = quotaManager->EnsureOriginIsInitialized(
-      persistenceType, mSuffix, mGroup, mOrigin, getter_AddRefs(dbDirectory));
+      persistenceType, mSuffix, mGroup, mOrigin,
+      /* aCreateIfNotExists */ true, getter_AddRefs(dbDirectory));
   if (NS_WARN_IF(NS_FAILED(rv))) {
     return rv;
   }

diff --git a/dom/localstorage/ActorsChild.cpp b/dom/localstorage/ActorsChild.cpp
@@ -70,9 +70,9 @@ mozilla::ipc::IPCResult LSDatabaseChild::RecvRequestAllowToClose() {
 }
 
 PBackgroundLSSnapshotChild* LSDatabaseChild::AllocPBackgroundLSSnapshotChild(
-    const nsString& aDocumentURI, const nsString& aKey,
-    const bool& aIncreasePeakUsage, const int64_t& aRequestedSize,
-    const int64_t& aMinSize, LSSnapshotInitInfo* aInitInfo) {
+    const nsString& aDocumentURI, const bool& aIncreasePeakUsage,
+    const int64_t& aRequestedSize, const int64_t& aMinSize,
+    LSSnapshotInitInfo* aInitInfo) {
   MOZ_CRASH("PBackgroundLSSnapshotChild actor should be manually constructed!");
 }
 
@@ -126,7 +126,7 @@ void LSObserverChild::ActorDestroy(ActorDestroyReason aWhy) {
 mozilla::ipc::IPCResult LSObserverChild::RecvObserve(
     const PrincipalInfo& aPrincipalInfo, const uint32_t& aPrivateBrowsingId,
     const nsString& aDocumentURI, const nsString& aKey,
-    const LSValue& aOldValue, const LSValue& aNewValue) {
+    const nsString& aOldValue, const nsString& aNewValue) {
   AssertIsOnOwningThread();
 
   if (!mObserver) {
@@ -140,8 +140,8 @@ mozilla::ipc::IPCResult LSObserverChild::RecvObserve(
     return IPC_FAIL_NO_REASON(this);
   }
 
-  Storage::NotifyChange(/* aStorage */ nullptr, principal, aKey,
-                        aOldValue.AsString(), aNewValue.AsString(),
+  Storage::NotifyChange(/* aStorage */ nullptr, principal, aKey, aOldValue,
+                        aNewValue,
                         /* aStorageType */ kLocalStorageType, aDocumentURI,
                         /* aIsPrivate */ !!aPrivateBrowsingId,
                         /* aImmediateDispatch */ true);

diff --git a/dom/localstorage/ActorsChild.h b/dom/localstorage/ActorsChild.h
@@ -78,9 +78,9 @@ class LSDatabaseChild final : public PBackgroundLSDatabaseChild {
   mozilla::ipc::IPCResult RecvRequestAllowToClose() override;
 
   PBackgroundLSSnapshotChild* AllocPBackgroundLSSnapshotChild(
-      const nsString& aDocumentURI, const nsString& aKey,
-      const bool& aIncreasePeakUsage, const int64_t& aRequestedSize,
-      const int64_t& aMinSize, LSSnapshotInitInfo* aInitInfo) override;
+      const nsString& aDocumentURI, const bool& aIncreasePeakUsage,
+      const int64_t& aRequestedSize, const int64_t& aMinSize,
+      LSSnapshotInitInfo* aInitInfo) override;
 
   bool DeallocPBackgroundLSSnapshotChild(
       PBackgroundLSSnapshotChild* aActor) override;
@@ -124,8 +124,8 @@ class LSObserverChild final : public PBackgroundLSObserverChild {
                                       const uint32_t& aPrivateBrowsingId,
                                       const nsString& aDocumentURI,
                                       const nsString& aKey,
-                                      const LSValue& aOldValue,
-                                      const LSValue& aNewValue) override;
+                                      const nsString& aOldValue,
+                                      const nsString& aNewValue) override;
 };
 
 /**