Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config to globally ignore errors #64

Closed
jeremiedbb opened this issue Mar 13, 2023 · 2 comments · Fixed by #69
Closed

Config to globally ignore errors #64

jeremiedbb opened this issue Mar 13, 2023 · 2 comments · Fixed by #69

Comments

@jeremiedbb
Copy link
Collaborator

Unless I missed something, the current way to ignore errors is to add # no-cython-lint on a line by line basis.
I can become cumbersome on a big project, where we'd like to ignore some errors globally. In flake8 you can pass --ignore=<coma separated list of errors to ignore>. What do you think about adding this functionality to cython-lint ?

As a second step, it would be even nicer to be able to write the config for cython-lint in the setup.cfg file of a project, e.g

[cython-lint]
max-line-length=88
ignore=E24,E121,...
@MarcoGorelli
Copy link
Owner

hi @jeremiedbb

Seems like a reasonable request - as the list of errors grows, it probably makes sense to add some configuration

Currently, all you can do is --no-pycodestyle and it'll turn off the style nitpicks, but I agree that it's probably time to introduce --ignore. @stefanv was also interested in this, so looking him in

it would be even nicer to be able to write the config for cython-lint in the setup.cfg file of a project

Sure - let's do pyproject.toml though, unless there's objections, as that's what the entire ecosystem is moving towards

@jeremiedbb
Copy link
Collaborator Author

Yes pyproject.toml makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants