Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect actions before, after #3

Merged
merged 2 commits into from
Dec 30, 2013
Merged

fixed incorrect actions before, after #3

merged 2 commits into from
Dec 30, 2013

Conversation

lkalinka
Copy link

Fixed wrong parameters, when called after and before

@marcojanssen
Copy link
Owner

What is wrong with the current handling of the before & after parameters? There is no need to check if it is callable, if it's not an exception will be thrown by Silex anyway..

@lkalinka
Copy link
Author

Yes exception will be thrown... But if You want to execute a class for action after & before(for example: OAuthCheck), this handling of parameters will return error for function call_user_func_array - that some of parameters null given expected string or else. This is solution for this problem. Give a try to execute some class for after or before and this error will occure.

@marcojanssen
Copy link
Owner

addActions is called by every parameter making this a nasty quickfix. We should add some validation for each property before trying to add it with addActions

marcojanssen added a commit that referenced this pull request Dec 30, 2013
fixed incorrect actions before, after
@marcojanssen marcojanssen merged commit c84bcad into marcojanssen:master Dec 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants