Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up README and exported functions #10

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

svilupp
Copy link
Collaborator

@svilupp svilupp commented Jan 11, 2024

Clean up code

  • Unexports the low-level API (commented out for reference)
  • Disable automatic REPL mode init (it doesn't work anyway)
  • Add a warning if someone initiates the REPL mode directly

Clean up README

  • Shuffle around the section
  • Remove broken functionality
  • Add more up-to-date model recommendation (I went for Dolphin; While in spirit OpenChat would have been better, its performance without their custom prompt template is bad. Doplhin seems to perform much better out of the box on a range of tasks).

Side-note: in repl.init my auto-formatter kicked in. I'll leave as is, as it will be resolved by the formatted PR anyway.

@svilupp svilupp requested a review from marcom January 11, 2024 09:38
@svilupp
Copy link
Collaborator Author

svilupp commented Jan 11, 2024

Rebased. Should be ready for review.

Once this is merged, we should probably tag.

@marcom marcom merged commit 706066c into main Jan 11, 2024
6 checks passed
@svilupp svilupp deleted the remove-low-level-api-clean-up-readme branch January 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants