Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code in README #14

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Improve code in README #14

merged 1 commit into from
Jun 5, 2024

Conversation

marcom
Copy link
Owner

@marcom marcom commented Jun 5, 2024

Fixes #13

@marcom
Copy link
Owner Author

marcom commented Jun 5, 2024

cc: @svilupp Any idea on the MacOS failures here? Seems to come from llama_cpp_jll

The errors are about an illegal instruction, perhaps there are some compile options active that use instructions on macos x86_64 that are not available on these cpus? I guess not that many people use that platform anymore, but might be worth fixing on the next llama_cpp_jll version bump.

I am merging this anyway as this is only a README fix.

The errors are of this kind:

[4298] signal (4.1): Illegal instruction: 4
in expression starting at /Users/runner/work/Llama.jl/Llama.jl/src/Llama.jl:12
_GLOBAL__sub_I_llama.cpp at /Users/runner/.julia/artifacts/242026219352e7e14af6046ae578398f1bce0d19/lib/libllama.dylib (unknown line)

@marcom marcom merged commit 97e4288 into main Jun 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download_model not defined error
1 participant