Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid null check in AzureChatGptServiceConfiguration.cs #122

Closed
N1K0232 opened this issue Oct 15, 2023 · 1 comment · Fixed by #127
Closed

Invalid null check in AzureChatGptServiceConfiguration.cs #122

N1K0232 opened this issue Oct 15, 2023 · 1 comment · Fixed by #127
Assignees
Labels
bug Something isn't working

Comments

@N1K0232
Copy link
Contributor

N1K0232 commented Oct 15, 2023

I noticed a problem in the two lines of code mentioned in the 2 links below

The problem is the following: the first "ArgumentNullException.ThrowIfNull" argument is the parameter that will be checked for nullability.
By passing a "nameof()" as parameter that value will never be null.

The signature of the "ArgumentNullException.ThrowIfNull" method is the following

public static void ThrowIfNull(object? argument, string? paramName = null)

Actually I found this problem only in the file mentioned in the title.
Can I solve this issue?

@marcominerva marcominerva added the bug Something isn't working label Oct 15, 2023
@marcominerva
Copy link
Owner

I think the problems are related to a bad copy/paste. I have assigned the issue to you, feel free to make a PR.

N1K0232 added a commit to N1K0232/ChatGptNet that referenced this issue Oct 16, 2023
marcominerva added a commit that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants