Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable annotations to ChatGptResponse and ChatGptChoice #98

Closed
marcominerva opened this issue Aug 3, 2023 · 0 comments · Fixed by #99
Closed

Add nullable annotations to ChatGptResponse and ChatGptChoice #98

marcominerva opened this issue Aug 3, 2023 · 0 comments · Fixed by #99
Assignees
@marcominerva
Labels
enhancement New feature or request

Comments

@marcominerva
Copy link
Owner

marcominerva commented Aug 3, 2023 •
edited

In the ChatGptResponse class, it is necessary to add nullable annotations for the following scenarios:

  • The PromptAnnotations property cannot be null when the IsPromptFiltered property is true.
  • The Error property is surely not null when the IsSuccessful property is false.

In the ChatGptChoice class, it is necessary to add nullable annotations for the following scenario:

  • The ContentFilterResults property cannot be null when the IsChoiceFiltered property is true.
@marcominerva marcominerva added the enhancement New feature or request label Aug 3, 2023
@marcominerva marcominerva self-assigned this Aug 3, 2023
marcominerva added a commit that referenced this issue Aug 3, 2023
@marcominerva
Add nullability annotations #98
67bc6b4
@marcominerva marcominerva mentioned this issue Aug 3, 2023
Merged
marcominerva added a commit that referenced this issue Aug 3, 2023
@marcominerva
Add nullable annotations #98 (#99)
8db82f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcominerva marcominerva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add nullable annotations #98 marcominerva/ChatGptNet
1 participant
@marcominerva