Merge pull request #57 from marcominerva/develop

Update Failure Reasons
marcominerva · Jun 17, 2024 · 53c3061 · 53c3061
2 parents 3ab09ef + a561871
commit 53c3061
Show file tree

Hide file tree

Showing 9 changed files with 52 additions and 17 deletions.
diff --git a/samples/Controllers/OperationResults.Sample/OperationResults.Sample.csproj b/samples/Controllers/OperationResults.Sample/OperationResults.Sample.csproj
@@ -6,8 +6,8 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.4" />
-        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.6.1" />
+        <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.6" />
+        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.6.2" />
         <PackageReference Include="TinyHelpers.AspNetCore" Version="3.1.4" />
     </ItemGroup>
 

diff --git a/samples/MinimalApis/OperationResults.Sample/OperationResults.Sample.csproj b/samples/MinimalApis/OperationResults.Sample/OperationResults.Sample.csproj
@@ -6,9 +6,9 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="8.0.4" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.4" />
-        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.6.1" />
+        <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="8.0.6" />
+        <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.6" />
+        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.6.2" />
     </ItemGroup>
 
     <ItemGroup>

diff --git a/...es/OperationResults.Sample.DataAccessLayer/OperationResults.Sample.DataAccessLayer.csproj b/...es/OperationResults.Sample.DataAccessLayer/OperationResults.Sample.DataAccessLayer.csproj
@@ -6,6 +6,6 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.4" />
+        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.6" />
     </ItemGroup>
 </Project>
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -9,7 +9,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Nerdbank.GitVersioning" Version="3.6.133"  PrivateAssets="All" />
+        <PackageReference Include="Nerdbank.GitVersioning" Version="3.6.139"  PrivateAssets="All" />
     </ItemGroup>
 
 </Project>
diff --git a/src/OperationResults.AspNetCore.Http/OperationResultOptions.cs b/src/OperationResults.AspNetCore.Http/OperationResultOptions.cs
@@ -10,6 +10,10 @@ public class OperationResultOptions
 
     public bool UseHttpStatusCodes { get; set; }
 
+    public UnmappedFailureReasonBehavior UnmappedFailureReasonBehavior { get; set; }
+
+    public int UnmappedFailureReasonStatusCode { get; set; } = StatusCodes.Status500InternalServerError;
+
     public OperationResultOptions()
     {
         StatusCodesMapping = new Dictionary<int, int>
@@ -30,7 +34,11 @@ internal int GetStatusCode(int failureReason, int? defaultStatusCode = null)
     {
         if (!StatusCodesMapping.TryGetValue(failureReason, out var statusCode))
         {
-            statusCode = defaultStatusCode.GetValueOrDefault(StatusCodes.Status501NotImplemented);
+            statusCode = UnmappedFailureReasonBehavior switch
+            {
+                UnmappedFailureReasonBehavior.UseDefaultStatusCode => defaultStatusCode.GetValueOrDefault(UnmappedFailureReasonStatusCode),
+                _ => failureReason
+            };
         }
 
         return statusCode;

diff --git a/src/OperationResults.AspNetCore.Http/UnmappedFailureReasonBehavior.cs b/src/OperationResults.AspNetCore.Http/UnmappedFailureReasonBehavior.cs
@@ -0,0 +1,7 @@
+namespace OperationResults.AspNetCore.Http;
+
+public enum UnmappedFailureReasonBehavior
+{
+    UseFailureReason,
+    UseDefaultStatusCode,
+}
diff --git a/src/OperationResults.AspNetCore/OperationResultOptions.cs b/src/OperationResults.AspNetCore/OperationResultOptions.cs
@@ -10,6 +10,10 @@ public class OperationResultOptions
 
     public bool UseHttpStatusCodes { get; set; }
 
+    public UnmappedFailureReasonBehavior UnmappedFailureReasonBehavior { get; set; }
+
+    public int UnmappedFailureReasonStatusCode { get; set; } = StatusCodes.Status500InternalServerError;
+
     public OperationResultOptions()
     {
         StatusCodesMapping = new Dictionary<int, int>
@@ -30,7 +34,11 @@ internal int GetStatusCode(int failureReason, int? defaultStatusCode = null)
     {
         if (!StatusCodesMapping.TryGetValue(failureReason, out var statusCode))
         {
-            statusCode = defaultStatusCode.GetValueOrDefault(StatusCodes.Status501NotImplemented);
+            statusCode = UnmappedFailureReasonBehavior switch
+            {
+                UnmappedFailureReasonBehavior.UseDefaultStatusCode => defaultStatusCode.GetValueOrDefault(UnmappedFailureReasonStatusCode),
+                _ => failureReason
+            };
         }
 
         return statusCode;

diff --git a/src/OperationResults.AspNetCore/UnmappedFailureReasonBehavior.cs b/src/OperationResults.AspNetCore/UnmappedFailureReasonBehavior.cs
@@ -0,0 +1,7 @@
+namespace OperationResults.AspNetCore;
+
+public enum UnmappedFailureReasonBehavior
+{
+    UseFailureReason,
+    UseDefaultStatusCode,
+}
diff --git a/src/OperationResults/FailureReasons.cs b/src/OperationResults/FailureReasons.cs
@@ -3,12 +3,17 @@
 public static class FailureReasons
 {
     public const int None = 0;
-    public const int ItemNotFound = 1;
-    public const int Forbidden = 2;
-    public const int DatabaseError = 3;
-    public const int ClientError = 4;
-    public const int InvalidFile = 5;
-    public const int Conflict = 6;
-    public const int Unauthorized = 7;
-    public const int GenericError = 8;
+    public const int ClientError = 1;
+    public const int Unauthorized = 2;
+    public const int Forbidden = 3;
+    public const int ItemNotFound = 4;
+    public const int InvalidRequest = 5;
+    public const int Timeout = 6;
+    public const int Conflict = 7;
+    public const int InvalidFile = 8;
+    public const int InvalidContent = 9;
+    public const int DatabaseError = 10;
+    public const int NetworkError = 11;
+    public const int ServiceUnavailable = 12;
+    public const int GenericError = 1000;
 }