Store ga tracking id into an env variable

marcomontalbano · Sep 19, 2019 · 9d757d6 · 9d757d6
1 parent af78086
commit 9d757d6
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/.env.sample b/.env.sample
@@ -3,3 +3,4 @@ CLOUDINARY_CLOUD_NAME=
 FACEBOOK_ACCESS_TOKEN=
 SITE_ID=
 NETLIFY_ACCESS_TOKEN=
+GA_TRACKING_ID=
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "video-to-markdown",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "private": true,
   "description": "How to embed a video in markdown? Here the answer. Add videos to your markdown files easier.",
   "homepage": "https://video-to-markdown.netlify.com/",

diff --git a/src/index.html b/src/index.html
@@ -30,7 +30,7 @@
                 var isProd = location.hostname === 'video-to-markdown.netlify.com';
                 if (isProd) {
                     window.ga = window.ga || function () { (ga.q = ga.q || []).push(arguments) }; ga.l = +new Date;
-                    ga('create', 'UA-50467643-11', 'auto');
+                    ga('create', process.env.GA_TRACKING_ID, 'auto');
                     ga('send', 'pageview');
                 }
             })();

diff --git a/src/lambda/classes/google-ua.js b/src/lambda/classes/google-ua.js
@@ -1,7 +1,9 @@
 const ua = require('universal-analytics');
-const visitor = ua('UA-50467643-11');
 const path = require('path');
 
+const { GA_TRACKING_ID } = process.env;
+const visitor = ua(GA_TRACKING_ID);
+
 const sendEvent = (...args) => {
     visitor.event(...args).send();
 }